This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
clean up , working builds on node v8.4.0 #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com>
daviddias
approved these changes
Sep 2, 2017
|
@ya7ya you mention tests but this PR doesn't include any. Could you confirm that you push everything you wanted? |
|
@diasdavid I meant to say builds, It was failing in Travis CI and locally when i updated node to v8.4.0. I'm editing this. |
|
@diasdavid sorry. nvm, I committed this too soon , It's failing tests here but it worked locally, investigating issue... |
|
Hi @ya7ya, I believe it is failing because it needs the need master (due ot ipfs-api release updates). I'm going to merge this into the branch and then do a master rebase and we shall see :) |
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
This switches pull-to-stream to v0.1.1 which includes a fix for ipfs#967 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
This was referenced Oct 16, 2022
This was referenced Oct 16, 2022
This was referenced Oct 17, 2022
This was referenced Oct 17, 2022
This was referenced Oct 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clean up for gateway (tested on node v6 and v8.4.0).
Current Todo:
go-ipfsgateway tests tojs-ipfsLicense: MIT
Signed-off-by: Yahya ya7yaz@gmail.com